ImranR98 / Obtainium

Get Android app updates straight from the source.
https://obtainium.imranr.dev
GNU General Public License v3.0
8.32k stars 183 forks source link

[Feature Request] Make Changelog Button More Obvious/Clickable #860

Closed keks24 closed 1 year ago

keks24 commented 1 year ago

Prerequisites

Describe the feature

I am currently using the following workflow:

  1. Open Optainium 1.1. Let it fetch all App information. 1.2. If there is an update (e.g. for Optainium), open the App page. 1.3. Click on the repository link: https://github.com/ImranR98/Obtainium
  2. In the opened default browser 2.1. Scroll down to the very bottom. 2.2. Click on the link Releases. 2.3. Read the release notes by clicking on Releases. 2.4. Close the default browser.
  3. Go back to Optainium.
  4. Update the App.

If the direct link to the releases page would be provided, the new workflow would then be like the following:

  1. Open Optainium 1.1. Let it fetch all App information. 1.2. If there is an update (e.g. for Optainium), open the App page. 1.3. Click on the releases link: https://github.com/ImranR98/Obtainium/releases
  2. In the opened default browser 2.1. Read the release notes. 2.2. Close the default browser.
  3. Go back to Optainium.
  4. Update the App.

Would it be possible to provide a direct link to the releases page of added repositories by default or maybe add a seperate customisable text field, which will overwrite the default link?

Describe alternatives you've considered (if applicable)

Keep using the current not-so-efficient workflow.

Additional context img1

-Ramon


PS: Nice issue template! You can actually put the descriptions in HTML comment tags (<!-- -->), so the reporter does not have to remove the text manually. Ansible has very nice issue templates for example. :)

ImranR98 commented 1 year ago

You can already see release notes directly in the app by clicking on the version number or release date on the main apps list page. Whether the link goes to the releases page or the main repo page is a matter of personal preference, I think it makes more sense as is.

ImranR98 commented 1 year ago

Thanks for the issue templates tip!

keks24 commented 1 year ago

You can already see release notes directly in the app by clicking on the version number or release date on the main apps list page.

I see! That was not obvious to me, that I can click on these.

Although, one needs to be super-precise with their fingers or thumbs to do this. There are three options to misclick:

  1. Open the in-App App page.
  2. Open the fetched Changelogs.
  3. Open the releases page in the default browser.

I actually like challenges, but this one should not be one.

Would it be possible to have clickable buttons for big, clumsy fingers? :smile:

img2

Whether the link goes to the releases page or the main repo page is a matter of personal preference, I think it makes more sense as is.

Agreed. Now that link makes more sense to me!


Just for the record; the built-in Changelog page: img1

ImranR98 commented 1 year ago
  1. Open the in-App App page.
  2. Open the fetched Changelogs.
  3. Open the releases page in the default browser.

3 should only happen if 2 is not implemented for that source. But yes the box could be made a bit bigger/outlined.

keks24 commented 1 year ago
  1. Open the in-App App page.
  2. Open the fetched Changelogs.
  3. Open the releases page in the default browser.

3 should only happen if 2 is not implemented for that source. But yes the box could be made a bit bigger/outlined.

I see, then I may have found a bug?

I have the following Apps added; sorted by release date in descending order:

img1

Clicking on DAVx5's link v4.3.6.1-ose, 2023-09-07, which is connected to their GitHub repository, opens their releases page in my default browser.

The links of Optainium, FairEmail, NewPipe SponsorBlock and FlorisBoard on the other hand, which are also added via their GitHub repository link, behave normally and open the Changes page.

Only the link of the App Aurora Store, which is from GitLab, opens their releases page in my default browser.

I can only guess, that it may be connected to DAVx5's release note formatting, which may be a markdown text block or so:

```no-highlight
<some_release_notes>


I am using `personal access tokens` for both platforms:

| Platform | Scope |
| -------: | :---- |
| GitHub | `repo/public_repo` |
| GitLab | `read_api` |

Should I open another issue for this?
ImranR98 commented 1 year ago

https://github.com/ImranR98/Obtainium/releases/tag/v0.14.11-beta

Touch targets are bigger and can optionally be highlighted (disabled by default).

ImranR98 commented 1 year ago

Also yes DAVx5 does their release notes in a way that doesn't show up in API requests for some reason.

keks24 commented 1 year ago

https://github.com/ImranR98/Obtainium/releases/tag/v0.14.11-beta

Touch targets are bigger and can optionally be highlighted (disabled by default).

Thank you very much for adapting this so quickly!

But I would like to note, that the highlighting does not work in dark mode (with and without high-contrast text). :)

Also yes DAVx5 does their release notes in a way that doesn't show up in API requests for some reason.

I am going to add another issue for this.

keks24 commented 1 year ago

I am going to add another issue for this.

See #875.

ImranR98 commented 1 year ago

But I would like to note, that the highlighting does not work in dark mode (with and without high-contrast text). :)

Fixed: https://github.com/ImranR98/Obtainium/releases/tag/v0.14.12-beta

keks24 commented 1 year ago

Awesome, works nicely!

BabyOilJohnson commented 1 year ago

@ImranR98 can u make it work for black theme too?

keks24 commented 1 year ago

I was tinkering with the App today and figured out, that you can update Apps directly from the main page; I always thought, that it just indicates a new update...:

img1

May I ask to highlight the download button as well?