Fix PublishAck to send variable header with packet id

Imroy / pubsubclient

A client library for the ESP8266 that provides support for MQTT

MIT License

433 stars 115 forks source link

Fix PublishAck to send variable header with packet id #76

Closed THKDev closed 7 years ago

THKDev commented 7 years ago

Patch fixes the acknowledgement of QOS1. Because of missing packet id a server like mosquitto does NOT remove a QOS1 message from queue. QOS1 message is resend every time the client does a reconnect.

Fix has been done according to: https://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718043

Imroy commented 7 years ago

Thanks, I just merged the first three. Note that when you create a pull request, you submit a branch. Any later commits to the branch also show up here. I knew I was taking my time responding to this pull and started panicking when your commit to change library.properties showed up. Then I realised you weren't trying to take control of the project, simply working on your master branch. Anyway, thanks.

THKDev commented 7 years ago

Sorry, this was my first pull request. I see what i did wrong. I made a pull request from my master. Is it possible to close this pull request, so that all future changes on my master branch wont show up here? regards thomas