search

In-Touch / laravel-newrelic

Laravel NewRelic ServiceProvider
173 stars 48 forks source link

Not working in Laravel 5.4 #46

Closed Vasiliy-Bondarenko closed 7 years ago

Vasiliy-Bondarenko commented 7 years ago

Call to undefined method Illuminate\Foundation\Application::share() in Intouch/LaravelNewrelic/NewrelicServiceProvider.php line 54

paunin commented 7 years ago

https://github.com/In-Touch/laravel-newrelic/pull/47

DanKeeble commented 7 years ago

@paunin That fix was specifically for Lumen. Would it be possible to get a fix for Laravel?

wins1908 commented 7 years ago

49

@pleckey @DanielKeeble could u merge to master and create a tag?

paunin commented 7 years ago

+1

kremsy commented 7 years ago

+1

honjoya commented 7 years ago

+1 Waiting the MR from @wins1908

jroman00 commented 7 years ago

+1

pleckey commented 7 years ago

Sorry folks - was stuck between job change (no longer with Intouch), traveling and sick. Intouch have been kind enough to leave me on as an admin for this project though, so I will now be able to keep up-to-date with it again.

PR#49 has been merged to master, and I'll cut a 5.4 tag and update readme shortly.

jroman00 commented 7 years ago

Any update on creating the new tag?

lukewaite commented 7 years ago

@pleckey I can tag this and update if you'd like. Were you thinking 2.2.x for the 5.4 compatible version?

pleckey commented 7 years ago

@jroman00 @lukewaite Tagged 2.2.0 for 5.4 and released.