search

In-Touch / laravel-newrelic

Laravel NewRelic ServiceProvider
173 stars 48 forks source link

Fix queue transaction listeners to work with Laravel/Lumen 5.3+ #61

Closed alies-dev closed 5 years ago

alies-dev commented 5 years ago

Fixes #60

Decisions

  1. Remove {data} {args} and {input} from variables that can be used to generate transaction name. All these variables added by PR #48. Reasons: New events don't have data property. It's still possible to fetch and parse them from ->job->payload() but this is not a good idea (IMO) performance-wise. Queue APi has been changed in Laravel 5.3 (commit). Since this issue fixes an bug added in prev. "patch" version (2.2.1), this fix should be release also as a "patch" version (2.2.X)
alies-dev commented 5 years ago

@brayansdt

brayansdt approved these changes 18 hours ago

Do you have any plans to marge this PR into master?

lukewaite commented 5 years ago

@lptn Thanks for the contribution. I've merged and tagged as v2.2.2.