search

InAnYan / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
0 stars 0 forks source link

Offer UI feedback on indexing #101

Closed koppor closed 3 months ago

koppor commented 3 months ago

We have this indexing progress monitor. However, the embedding doesn't seem to be part of it?

image

InAnYan commented 3 months ago

According to Carl, there is a way to show users the background task (showToUser(boolean)), but there is no way to remove background task from progress monitor, once it's completed :)

What should we do? I think this issue connects not only to my AI PR, but to the whole JabRef (about removing background tasks)

InAnYan commented 3 months ago

Should be done.

Check, do you like it?

If you see that the task is not gone in progress indicator, then refer to https://github.com/InAnYan/jabref/issues/101#issuecomment-2267402766

koppor commented 3 months ago

According to Carl, there is a way to show users the background task (showToUser(boolean)), but there is no way to remove background task from progress monitor, once it's completed :)

Just for tracking. It is a ControlfsFX control. One needs to work on that. Or on its usage in JabRef.

koppor commented 3 months ago

Looks better:

image

The text "57% work done ..." is a text mirroring the title and the progress bar. That should be removed. (If you keep it, all other progress bar texts need to be adapted. For consistency)

InAnYan commented 3 months ago

Hey, here is the "downloading embedding model" :laughing:

InAnYan commented 3 months ago

I removed it.

I think you can close this issue, and then answer me at: https://github.com/InAnYan/jabref/issues/115#issuecomment-2268676089

koppor commented 3 months ago

I'll close with the hope, you can address everything at once ^^