InAnYan / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
0 stars 0 forks source link

Handle change of citation keys. #113

Closed koppor closed 3 months ago

koppor commented 3 months ago
  1. I chat with BibEntry with citationkey A.
  2. I change the citation key to B
  3. I reopen the AI chat
  4. Chat is empty

Expectation: Chat is the same after step 1.


Idea to solve:

  1. Listen to entry changed events
  2. Filter on citatoin key change
  3. Stop if key is changed to something "invalid"
  4. get messages for oldkey
  5. Store messages to newkey
  6. Remove messages for oldkey
InAnYan commented 3 months ago

~I think I figured it out how to implement it.~

But, what if user changes entry to an invalid citation key (empty or non-unique)?

InAnYan commented 3 months ago

Okay, I implemented this feature, but the fix doesn't take into account invalid citation keys...

koppor commented 3 months ago

Does not work with current pull.

I tried with Ctrl+G for generating a new key. (Before, I changed the key pattern to have abc at the end).

InAnYan commented 3 months ago

1) I've tried to add some letters after the citation key, and it worked 2) I tried Ctrl+G and click on "Generate" button. It worked too

Maybe you had some past push without the change? Could you try again?

@ThiloteE, maybe you can also try this?

koppor commented 3 months ago

I think, it happens if a paper was not summarized at all - then summary, then key change, then back to the tab


image


Long form:

1

image

2

image

3

image

4

image

image

InAnYan commented 3 months ago

OH NO

I'm sorry, I've only implemented this for chats :laughing:

InAnYan commented 3 months ago

Yes. Now it should work

koppor commented 3 months ago

Tried with one entry. Works.