search

InAnYan / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
0 stars 0 forks source link

Change size to "about 400 MB" #143

Closed koppor closed 3 months ago

koppor commented 3 months ago

Do you have an idea how often the size will change?

Are there code comments pointing to the places in the code if DJL changes the default embedding model?

I think, "382" is a too fine-grained number. Remember, all texts need to be translated. And JabRef translators are lazy ^^.

image

I would propose to use "about 400 MB"

InAnYan commented 3 months ago

Size won't change at all.

It depends on the selected embedding model.

Size may vary a lot, so I use FileUtils.byteCountToDisplaySize. Is there an internationalized method like that?

InAnYan commented 3 months ago

Size text is not translated. In the translation message there is %0, which I replace with the results of FileUtils.byteCountToDisplaySize

InAnYan commented 3 months ago

If a translated variant is still needed, then I can code "nicer" solution (like in https://github.com/InAnYan/jabref/issues/145), with "less than 50 MB", "100 MB", etc.

But I like more what we have now: 1) It's more accurate 2) MB, GB - I think those terms are heard all over the world and everyone knows them, so maybe this it's not priority (but I'm pretty sure I could be wrong here..)

koppor commented 3 months ago

Thank you for the explanation!