InAnYan / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
0 stars 0 forks source link

No files found is a warning, not an error #176

Open koppor opened 3 months ago

koppor commented 3 months ago

image

An error is something that blocks the result (like exceptions). A missing file is nothing that special.

Please change to warning.

The only error is if no file is attached at all, because then no chatting is possible.

InAnYan commented 3 months ago

Notifications window looks good on your machine)

InAnYan commented 3 months ago

Now, to the issue:

I've made it an error because it blocks the chatting with the entry, so AI won't be able to give any results from the entry because there are no files attached.

The only error is if no file is attached at all, because then no chatting is possible.

I think you meant if all entries don't have attached files?

If we remove error from here, then notifications probably shouldn't have types.

So should I remove it?

InAnYan commented 3 months ago

Hmm, maybe it would be better to rename notifications (or tooltip) to something else... like "files status", or "AI chat status".

But "notifications" seems easy

koppor commented 2 months ago

State of today

image

koppor commented 2 months ago

Now, to the issue:

I've made it an error because it blocks the chatting with the entry, so AI won't be able to give any results from the entry because there are no files attached.

I am chatting with a group of bib entries. two hundred. I am able to chat.

So should I remove it?

You can keep LOGGER.debug. But not do a notification.


I am talking about the group chat!!!

For single AI chat tab, it works.

koppor commented 2 months ago

The thing is, JabRef has a nice UI to show for which entries in a group there is no attached file:

image

There is no need to put warnings. A user should know that chatting with content requries content.

InAnYan commented 2 months ago

@koppor I see. Should I remove notification "No files attached" whatsoever?

InAnYan commented 2 months ago

And it doesn't mean that you won't be able to chat. It says "AI won't extract information from those entries".

Can I leave only one notification, where I list all the entries without files? Well, probably that's not a good idea, if there are many entries without files

koppor commented 2 months ago

And it doesn't mean that you won't be able to chat. It says "AI won't extract information from those entries".

Can I leave only one notification, where I list all the entries without files? Well, probably that's not a good idea, if there are many entries without files

Show it only, if NO ENTRY has a file attached. Then, it makes sense.

In all other cases, the other places of the JabRef UI guide the user.

InAnYan commented 2 months ago

Should be fixed

InAnYan commented 2 months ago

Show it only, if NO ENTRY has a file attached. Then, it makes sense.

Just in case, there is such functionality :)

koppor commented 2 months ago

For dumb users, please also add a warning if no entries are there:

image

koppor commented 2 months ago

No files: no error :-(

image

InAnYan commented 2 months ago

sorry, I just was sure I made this for all AI chat component, but probably this feature is only available for entry chat

koppor commented 1 month ago

Current behavior if no files are attached:

image