InBetweenNames / gentooLTO

A Gentoo Portage configuration for building with -O3, Graphite, and LTO optimizations
GNU General Public License v2.0
571 stars 96 forks source link

sys-config/ltoize USE=keep-nocommon dosym for nocommon.conf missing line continuation #553

Closed corrmaan closed 4 years ago

corrmaan commented 4 years ago
 * Messages for package sys-config/ltoize-0.9.6:

 * Package:    sys-config/ltoize-0.9.6
 * Repository: lto-overlay
 * Maintainer: lookatyouhacker@gmail.com
 * USE:        abi_x86_64 amd64 elibc_glibc keep-nocommon kernel_linux userland_GNU
 * FEATURES:   network-sandbox preserve-libs sandbox userpriv usersandbox
 * FEATURES='assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-elog strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr'
 * CFLAGS='-march=skylake -mabm -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=16 -fuse-linker-plugin -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed'
 * CXXFLAGS='-march=skylake -mabm -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=16 -fuse-linker-plugin -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed'
 * FFLAGS='-march=skylake -mabm -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=16 -fuse-linker-plugin -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed'
 * FCFLAGS='-march=skylake -mabm -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=16 -fuse-linker-plugin -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed'
 * F77FLAGS='-march=skylake -mabm -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=16 -fuse-linker-plugin -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed'
 * LDFLAGS='-Wl,-O1 -Wl,--as-needed -march=skylake -mabm -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=16 -fuse-linker-plugin -pipe -falign-functions=32'
 * MAKEOPTS='-j17'
 * gcc (Gentoo 9.3.0-r1 p3) 9.3.0
 * g++ (Gentoo 9.3.0-r1 p3) 9.3.0
 * GNU ld (Gentoo 2.34 p4) 2.34.0
 * Linux vegeta 5.7.9-gentoo-x86_64 #18 SMP Fri Jul 17 15:30:26 ADT 2020 x86_64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz GenuineIntel GNU/Linux
 * Warning: Active GCC version < 10.1.0, it is recommended that you use the newest GCC if you want LTO.
 * I_KNOW_WHAT_I_AM_DOING=y -- continuing anyway
 * Final size of build directory: 0 KiB
 * Final size of installed tree:  0 KiB
 * removing unneeded *.la files
 * Installing make.conf.lto.defines definitions for optimizations used in this overlay
 * Installing make.conf.lto default full optimization config for make.conf
 * Installing ltoworkarounds.conf package.cflags overrides
 * ERROR: sys-config/ltoize-0.9.6::lto-overlay failed (preinst phase):
 *   dosym: two arguments needed
 * 
 * If you need support, post the output of `emerge --info '=sys-config/ltoize-0.9.6::lto-overlay'`,
 * the complete build log and the output of `emerge -pqv '=sys-config/ltoize-0.9.6::lto-overlay'`.
 * The complete build log is located at '/var/tmp/portage/sys-config/ltoize-0.9.6/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-config/ltoize-0.9.6/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-config/ltoize-0.9.6/homedir'
 * S: '/var/tmp/portage/sys-config/ltoize-0.9.6/work/ltoize-0.9.6'

Proposed patch:

--- ltoize-0.9.6.ebuild 2020-07-20 09:27:42.039153426 -0300
+++ ltoize-0.9.6-r1.ebuild  2020-07-20 09:28:56.559154805 -0300
@@ -75,7 +75,7 @@
    dosym "${LTO_PORTAGE_DIR}/package.cflags/ltoworkarounds.conf" "${PORTAGE_CONFIGROOT%/}/etc/portage/package.cflags/ltoworkarounds.conf"

    #Install -fno-common workarounds file
-   use keep-nocommon && dosym "${LTO_PORTAGE_DIR}/package.cflags/nocommon.conf"
+   use keep-nocommon && dosym "${LTO_PORTAGE_DIR}/package.cflags/nocommon.conf" \
    "${PORTAGE_CONFIGROOT%/}/etc/portage/package.cflags/nocommon.conf"

    #Install patch framework

Many thanks for putting in this USE flag for those who are still on gcc-9.

InBetweenNames commented 4 years ago

Argh, can't believe I missed that! Thanks for the patch!