InBetweenNames / gentooLTO

A Gentoo Portage configuration for building with -O3, Graphite, and LTO optimizations
GNU General Public License v2.0
571 stars 96 forks source link

Obsolete flags #859

Open mccarverone opened 2 years ago

mccarverone commented 2 years ago

By running the nice utility eix-test-obsolete it turns out that the following flags entries are operating on non existent packages. Many might have just been renamed, or they are no longer in main gentoo repository. Shall we remove them altogether? Would you care for a few commits?

Non-matching or empty entries in /etc/portage/package.cflags:
www-client/torbrowser *FLAGS-="${IPAPTA}"
=sys-apps/gawk-4.1.4 *FLAGS-="${IPAPTA}"
dev-qt/qtwebkit *FLAGS-="${IPAPTA}"
app-emulation/libpod *FLAGS-=-flto*
<app-text/mupdf-1.12.0 *FLAGS-=-flto*
cross-arm-none-eabi/newlib *FLAGS-=-flto*
cross-i686-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
cross-x86_64-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
games-fps/zandronum *FLAGS-=-flto*
dev-libs/intel-neo *FLAGS-=-flto*
dev-qt/qtwebkit *FLAGS-=-flto*
dev-tex/chktex "use pcre && FlagSubAllFlags -flto*"
games-emulation/mupen64plus-libretro *FLAGS-=-flto*
games-emulation/parallel-n64-libretro *FLAGS-=-flto*
net-libs/webkit-gtk:3 *FLAGS-=-flto*
sci-libs/arrayfire *FLAGS-=-flto*
sci-libs/scipy *FLAGS-=-flto*
sys-apps/nix *FLAGS-=-flto*
sys-fabric/libibverbs *FLAGS-=-flto*
dev-util/cargo *FLAGS+=-ffat-lto-objects
dev-python/notify-python NOCOMMON_OVERRIDE_LIBTOOL=yes
gnome-base/libgnome-keyring NOCOMMON_OVERRIDE_LIBTOOL=yes
gui-apps/gammastep *FLAGS+='-fno-finite-math-only'
<media-libs/opus-1.3.1-r1 /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
media-sound/mumble /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
www-client/torbrowser *FLAGS-="-mtls-dialect=gnu2"
SigHunter commented 1 year ago

the current list of obsolete packages in package.cflags are

Non-matching or empty entries in /etc/portage/package.cflags:
www-client/torbrowser *FLAGS-="${IPAPTA}"
=sys-apps/gawk-4.1.4 *FLAGS-="${IPAPTA}"
dev-qt/qtwebkit *FLAGS-="${IPAPTA}"
app-emulation/libpod *FLAGS-=-flto*
<app-text/mupdf-1.12.0 *FLAGS-=-flto*
cross-arm-none-eabi/newlib *FLAGS-=-flto*
cross-i686-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
cross-x86_64-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
games-fps/zandronum *FLAGS-=-flto*
dev-libs/intel-neo *FLAGS-=-flto*
dev-qt/qtwebkit *FLAGS-=-flto*
dev-tex/chktex "use pcre && FlagSubAllFlags -flto*"
games-emulation/mupen64plus-libretro *FLAGS-=-flto*
games-emulation/parallel-n64-libretro *FLAGS-=-flto*
net-libs/webkit-gtk:3 *FLAGS-=-flto*
sci-libs/arrayfire *FLAGS-=-flto*
sci-libs/scipy *FLAGS-=-flto*
sys-apps/nix *FLAGS-=-flto*
sys-fabric/libibverbs *FLAGS-=-flto*
www-misc/shellinabox *FLAGS-=-flto*
dev-util/cargo *FLAGS+=-ffat-lto-objects
=sys-libs/efivar-37 *FLAGS+="-flto-partition=none"
media-libs/ilmbase *FLAGS+=-lrt
dev-python/notify-python NOCOMMON_OVERRIDE_LIBTOOL=yes
gnome-base/gconf NOCOMMON_OVERRIDE_LIBTOOL=yes
gnome-base/libgnome-keyring NOCOMMON_OVERRIDE_LIBTOOL=yes
gui-apps/gammastep *FLAGS+='-fno-finite-math-only'
<media-libs/opus-1.3.1-r1 /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
media-sound/mumble /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
www-client/torbrowser *FLAGS-="-mtls-dialect=gnu2"

those entries currently do not do anything because the corresponding packages do not exist in ::gentoo repository and could therefore, in my understanding, be removed without impact. or some of them could be matched to the current package in case of renaming (like media-sound/mumble is net-voip/mumble)

do they need to be keept for backwards compatibility? this messes up eix-test-obsolete :)

wolfwood commented 1 year ago

renames and deprecated packages are one thing, but packages from common overlays (which you personally do not have) shouldn't be excluded.

in addition, the way cross-dev works is by creating a local overlay with a cross-* prefix and those patches are very necessary to keep those toolchains working.