search

InBrowserApp / tldr.inbrowser.app

📝 tldr InBrowser.App is a offline-capable PWA for tldr-pages. Fully runs in your browser. Zero API latency.
https://tldr.inbrowser.app
MIT License
203 stars 21 forks source link

Automatic platform search filter detection (based on host platform) "may be" problematic #22

Open diraneyya opened 7 months ago

diraneyya commented 7 months ago

Hello there,

I am an educator and I have always been very passionate about this project. Hence as a first issue I would like to take a moment to thank everyone who played a part in bringing this concept to life. It has changed the lives of hundreds of my students. It namely made them see that despite the lengthy manpages, the actual use cases are often tangible, easy-to-understand and can be adapted with little effort.

I just now tried to look up package manager commands like apk for alpine and apt-get for most Linux systems and I was surprised not to find anything. I also tried apt-get-update as the case with git commands.

Did I fail to find the TLDR pages? And if these commands were excluded from the project, then may I ask why?

NOTE: This is a content-related issue.

rwv commented 7 months ago

apk and apt is a linux command therefore you need select Linux in the platform selection. Although Linux should be included by default. What’s your setup?

Thank you for your like!

diraneyya commented 7 months ago

Thank you for the reply!

It turns out that this indeed was the issue!

image

As seen above searching for apk out of the box does not yield the article, which exists under the Linux platform. By clicking on the gear ⚙ icon however, it is possible to include the Linux platform.

image

I realised that the reason for this might have been the fact that I am running a Mac OS X. However, I was at this instance writing a docker file, so this was a little confusing to me.

As neat of a feature as it might be to toggle the platform based on the operating system of the user, I find that not necessarily to be the right thing, considering the use of this website/service as a reference 📚

I am going to change the title of the issue to make it more useful in case you decide to revise this default behaviour.

rwv commented 7 months ago

https://github.com/InBrowserApp/tldr.inbrowser.app/blob/0c683a4c00cb376288c4d82ed91bf3165b339c83/src/components/search/composables/getDefaultPlatforms.ts#L13

rwv commented 7 months ago

linux is already included by default. Maybe you used tldr.inbrowser.app before this change is made. You can try this in a new browser and check the default behavior.