search

InFact-coop / building-exploratory

App for accessing the listed buildings in the borough of Islington
MIT License
1 stars 0 forks source link

Testing scroll #34

Closed sohilpandya closed 6 years ago

sohilpandya commented 6 years ago

Please review after #33 Added basic ability to select map to go to the point and vice a versa

emilyb7 commented 6 years ago

Hey! I've left a couple of comments. Code here is generally fine. However, not really sure that scrolling is working for me?

Am I right in understanding that if I have the building details panel open, and I then select another building from the map, it's supposed to jump back up to the top?

Because that's not happening. At the moment, it either doesn't work at all, or it just jumps part of the way up. It probably depends on my current scoll position.

sohilpandya commented 6 years ago

@emilyb7 You are correct. I'll merge this in and fix it in a later PR.