search

InFinity54 / LoR_DDragon_Adventure

Part of the LoR_DDragon repository. Contains data related to Path of Champions game mode of Legends of Runeterra.
0 stars 0 forks source link

Adding Champions Icons/pictures #1

Closed LeagueOfLindemann closed 1 month ago

LeagueOfLindemann commented 2 months ago

Hi LoR_DDragon_Adventure team

I would like to suggest the inclusion of Champion Icons and Champions pictures. this would help getting that images without the hassle of getting manually.

Champion Icon (Can be circular version when it appears in bottom-left when you are exploring map) and/or an square avatar-like

Champion picture: as they appear at champion selection in PoC without elements (faction, level, stars, etc) Including this would help website/app developers focused in Adventure mode in getting all champions pictures/icons to illustrate their guides and show champions properly :D

thanks in advance for reading my suggestion. I think this addition would be useful for everyone who downloads the DDragon for adventure mode :D

InFinity54 commented 2 months ago

Hi! 🙂

I'm not playing a lot to LoR, so I'm not an expert, but from what I know from this gamemode, champions avatars and champions pictures are the same picture, which is a full splash version of cards used in-game.

Riot split data from LoR into many "folders" , which are in fact (many) zipped files, one per language and "folder" (adventure/core/setX). I left them separated because of GitHub repository limits (but they are reunited in a global repository using Git submodules). You can find the cards splash you need in LoR sets repositories, but I agree that Riot have a very special way to store LoR files in DDragon which makes it difficult to find a particular file. To find a champion splash, you need to first find the champion internal card ID to be able to find its splash. For example, Jinx is internally registered in set 1 has card 01PZ040. The full splash is available in set 1 repository, in img\cards\{langcode}\01PZ040-full.png : 01PZ040-full

The only way I have to add champions splashs into this subrepository is to find them manually (because Riot doesn't give any data about champions used in this gamemode, only items/powers/relics), which is going to be time consuming and a duplicate of already existing data (which is going to increase LoR DDragon size, which is already (very) heavy). 😕

I'm going to try to find a way to automate this process, but I can't guarantee that I'm going to be able to add these champions avatars into this repository.

I let the issue opened until I can answer it more definitely. 😉

Have a nice day!

InFinity54 commented 2 months ago

Hi again!

Requested images has been added to this repository (and to the global one). You can find them in img/champions folder. image

Note that avatars are manually centered, so they may be slightly offset. If it's really annoying, let me know which ones and I'll try to improve them. 🙂

I let you close this issue if it's good for you. 😉

Have a nice day!