Open matu3ba opened 2 years ago
Thank you for the links.
I'll note here that although I've left a good few of the ENABLE_GUARDs in tact, I did explicitly decide to omit a few, namely:
ENABLE_STATISTICS
: to simplify codeENABLE_ADAPTIVE_THREAD_CACHE
: similar reason to ENABLE_STATISTICS
. But as opposed to what the name would lead one to believe, it doesn't actually appear to be used in any sort of adaptive thread caching, seeming to exclusively exist as an add-on to ENABLE_STATISTICS
.ENABLE_OVERRIDE
& ENABLE_PRELOAD
: laziness and lack of infrastructureENABLE_VALIDATE_ARGS
: most of the validation this enabled seemed like it shouldn't be disabled in the first place, and the one instance where it seemed reasonable seemed like it'd be better determined by std.debug.runtime_safety
.That is of course all based partly off of investigation and my intuition.
Ah, lol. I did no expect the port to be done already. My criticism on missing metrics + docs was mainly on the upstream project.
Great idea to port rpmalloc. I suggested this also on reddit. :)
benches
testing
metrics + docs