search

InPreD / PRONTO

rePort geneRator fOr iNpred Tumor bOards
GNU General Public License v3.0
0 stars 4 forks source link

sys.exit(0) when exiting on error #16

Closed tinavisnovska closed 8 months ago

tinavisnovska commented 8 months ago

The script uses sys.exit(0) when exiting on an error which makes it difficult to catch errors as usually 0 stands for a job exiting correctly while a higher number stands for an error.

xiaoliz0 commented 8 months ago

Not sure which error you mean. If you could give an example, I could check further.

tinavisnovska commented 8 months ago

in PRONTO-1.0, Script/PRONTO.py lines 83, 149, 287, 970, 977, 991, 1032.

xiaoliz0 commented 8 months ago

Emm, most of the places you listed. In my personal view, if the error comes from the technical part (system, OS, running environment...) then the exit should be higher than 0. The number is given to the system to verify if the error is for itself which normally should cause something like SystemExit. And for other errors (dataset content mistakes, human typing errors, againstting rules defined by person...), they are not really errors for the system or OS. They are some "error" defined by the script/human. So I print the error message (to show why this is an error) and let the script exit with 0. This is more personal programming habits. Thanks for your suggestions any way! I will check the script further in details.