search

InPreD / PRONTO

rePort geneRator fOr iNpred Tumor bOards
GNU General Public License v3.0
0 stars 4 forks source link

Updates from develop_OUS to main #36

Closed xiaoliz0 closed 2 months ago

xiaoliz0 commented 4 months ago

A few updates from the requests and the issues created in GitHub. All the updates are tested for a while in OUS. It is nice all of you could take a check and we could plan a new releasing soon.

marrip commented 2 months ago

Hey Xiaoli,

thank you for responding to all those points we made. It is good that you created all those issues which divide the work into smaller pieces that can be handled more easily. I just wanted to say that PRs usually are there for addressing smaller issues directly and actually making those changes in the PR itself but for now we can stick to the issues you created.

I also wanted to suggest that we can split the work and we all can pick out issues from the list, work on them and open a PR to get them into the code base if that is ok with you?

xiaoliz0 commented 2 months ago

Hey Xiaoli,

thank you for responding to all those points we made. It is good that you created all those issues which divide the work into smaller pieces that can be handled more easily. I just wanted to say that PRs usually are there for addressing smaller issues directly and actually making those changes in the PR itself but for now we can stick to the issues you created.

I also wanted to suggest that we can split the work and we all can pick out issues from the list, work on them and open a PR to get them into the code base if that is ok with you?

Hei Martin, It is very nice suggestion! Yes, It is okay for me to divide the tasks for different issues. The PR needs to be reviewed by most of us. I will let current PR through after all the issues are created. Then we could continue the development for a while. Maybe another new releasing before that?

marrip commented 2 months ago

Hey Xiaoli, thank you for responding to all those points we made. It is good that you created all those issues which divide the work into smaller pieces that can be handled more easily. I just wanted to say that PRs usually are there for addressing smaller issues directly and actually making those changes in the PR itself but for now we can stick to the issues you created. I also wanted to suggest that we can split the work and we all can pick out issues from the list, work on them and open a PR to get them into the code base if that is ok with you?

Hei Martin, It is very nice suggestion! Yes, It is okay for me to divide the tasks for different issues. The PR needs to be reviewed by most of us. I will let current PR through after all the issues are created. Then we could continue the development for a while. Maybe another new releasing before that?

I guess you have to check with Tina and Jone who also made suggestions, for me it is fine if issues are created and we take it from there.

tinavisnovska commented 2 months ago

Hey Xiaoli,

thank you for responding to all those points we made. It is good that you created all those issues which divide the work into smaller pieces that can be handled more easily. I just wanted to say that PRs usually are there for addressing smaller issues directly and actually making those changes in the PR itself but for now we can stick to the issues you created.

I also wanted to suggest that we can split the work and we all can pick out issues from the list, work on them and open a PR to get them into the code base if that is ok with you?

Hey Xiaoli, thank you for responding to all those points we made. It is good that you created all those issues which divide the work into smaller pieces that can be handled more easily. I just wanted to say that PRs usually are there for addressing smaller issues directly and actually making those changes in the PR itself but for now we can stick to the issues you created. I also wanted to suggest that we can split the work and we all can pick out issues from the list, work on them and open a PR to get them into the code base if that is ok with you?

Hei Martin, It is very nice suggestion! Yes, It is okay for me to divide the tasks for different issues. The PR needs to be reviewed by most of us. I will let current PR through after all the issues are created. Then we could continue the development for a while. Maybe another new releasing before that?

I guess you have to check with Tina and Jone who also made suggestions, for me it is fine if issues are created and we take it from there.

Regarding my suggestions, those are mostly code improvements, not much impact on functionality itself. So Xiaoli, if you think you want to make a release now and include the code changes later on, go for it.