It would be nice to separate 'graphical' and 'functional' parts of the code to separate functions. I know this is quite some work, but I also believe it would be worth from the perspective of readability. #46
It would be nice to separate 'graphical' and 'functional' parts of the code to separate functions. I know this is quite some work, but I also believe it would be worth from the perspective of readability.
Here is just a small example - lines 1432-1454 - a new function set_slide6_layout_parameters is defined below for dealing with various slide6 layout parameters and a new dictionary slide6_layout_params is defined to hold all the parameters in one data structure instead of all the different variables:
and afterwards all the 'slide6' variables used as inputs in insert_table_to_ppt() can be reduced to 'slide6_layout_params' and read from the dictionary inside the function as needed.
Hopefully I did not forget any other place where the slide6 variables are used...
Here is just a small example - lines 1432-1454 - a new function
set_slide6_layout_parameters
is defined below for dealing with various slide6 layout parameters and a new dictionaryslide6_layout_params
is defined to hold all the parameters in one data structure instead of all the different variables:then one can use the function in the main like in the last line here:
and afterwards all the 'slide6' variables used as inputs in
insert_table_to_ppt()
can be reduced to 'slide6_layout_params' and read from the dictionary inside the function as needed.Hopefully I did not forget any other place where the
slide6
variables are used..._Originally posted by @tinavisnovska in https://github.com/InPreD/PRONTO/pull/36#discussion_r1627452875_