search

InQuest / ThreatIngestor

Extract and aggregate threat intelligence.
https://inquest.readthedocs.io/projects/threatingestor/
GNU General Public License v2.0
821 stars 135 forks source link

An issue with PyMISP #81

Closed ninoseki closed 4 years ago

ninoseki commented 4 years ago

The latest version of PyMISP(v2.4.120) drops following methods which ThreatIngestor uses. (ref. https://github.com/MISP/PyMISP/commit/24a8f90ea830d780c13cf8383442990a3e4863b3#diff-0645334504f5c27e7d42e1f0f3cb8d6aL927-L948)

So, as a temporary solution, prohibiting using the latest PyMISP is good IMHO. (Note: I confirmed that ThreatIngestor works with PyMISP v2.4.119)

ninoseki commented 4 years ago

I created two PRs to fix this issue.

My preferable one is #83 but of course the choice is yours.

ninoseki commented 4 years ago

@cmmorrow Now you can remove PyMISP's version restriction which is introduced by #82. https://github.com/InQuest/ThreatIngestor/blob/master/setup.py#L26 Or should I make a patch for that?

cmmorrow commented 4 years ago

If you submit a PR for it, I'll merge it.