search

InQuest / iocextract

Defanged Indicator of Compromise (IOC) Extractor.
https://inquest.readthedocs.io/projects/iocextract/
GNU General Public License v2.0
505 stars 91 forks source link

Fix IPv6 length check #80

Closed Synse closed 3 months ago

Synse commented 3 months ago

This PR fixes the minimum length check for extracted IPv6 addresses.

The current implementation is checking the length of the the data (input string) that IPs were extracted from, not the extracted IP address. This is causing extract_ipv6s() to extract time values:

Before

>>> from iocextract import extract_ipv6s
>>> list(extract_ipv6s("Today is 2024-07-18 and it is currently 23:06:41 UTC"))
['23:06:41']
>>>

After

>>> from iocextract import extract_ipv6s
>>> list(extract_ipv6s("Today is 2024-07-18 and it is currently 23:06:41 UTC"))
[]
>>>

:mag: References

DragonistYJ commented 3 months ago

您好，我已经收到您的周报，周报收取截止时间为每周二下午八点，八点后将截止收取，请按时发送您的周报，谢谢！

Synse commented 3 months ago

@JosiahRaySmith Do you know when the next iocextract release will be? No rush as we're working around this for now but would like to update whenever this fix is available. :bow: