BTC addresses are recognized as usernames

[deadbits]

Primary Question / Request

BTC addresses are being recognized and stored as usernames 😢

What type of request is there?

• [ ] Breaking bug
• [x] General error (non-fatal)
• [ ] Additional module (Create a pull request! :D)
• [ ] Use-case suggestions
• [ ] Workflow improvements

Please explain the bug in a clear and concise manner

Steps to Recreate (If Applicable)

• start cli
• create new artifact with BTC addr 37KW5474sQmxcnqsc88zGWPL74a1m48iUj

  omnibus >> new 37KW5474sQmxcnqsc88zGWPL74a1m48iUj
  [~] Created new artifact (37KW5474sQmxcnqsc88zGWPL74a1m48iUj - user)
  [~] Opened new session
  Artifact ID: 1
  omnibus >> blockchain 1
  {
  "total_sent": 50000000,
  "total_received": 50000000,
  "final_balance": 0,
  "address": "37KW5474sQmxcnqsc88zGWPL74a1m48iUj",
  "hash160": "3dbf1968b3b1010523d62c818d76b75be81b3701",
  "txs": [
      { ...

  Is this preventing you from using the application?

• [ ] Yes
• [x] No

If you selected Yes, please explain why

Do you have any screenshots, log output, tracebacks, or otherwise to support your requests?

[deadbits]

• [x] Changed base58 logic to use regex for verifying BTC addresses.
• [x] Updated detect_type to leverage new is_btc (regex based) function
• [x] Tested this works in app and stores addresses correctly now
• [ ] Push to master branch

[deadbits]

Need to push this to master branch.. I made the mistake of working on too much in one branch, including this feature. This week I'll separate it all back out and push this bug fix ASAP.