search

InSyncWithFoo / pyright-for-pycharm

Pyright integration for PyCharm
https://insyncwithfoo.github.io/pyright-for-pycharm/
MIT License
58 stars 3 forks source link

Code completions suggestions are doubled up #64

Open mmdanggg2 opened 3 months ago

mmdanggg2 commented 3 months ago

What happened?

When getting code suggestions it is showing both suggestions from PyCharm and from Pyright: image The Pyright function suggestions also do not include the calling brackets as I would expect. It would be nice to have an option to disable one or the other.

Steps to reproduce

Open the code suggestions dialog, see that there are two entries for each member

Relevant log output or stack trace

No response

Operating system

Linux

InSyncWithFoo commented 3 months ago

This is not a bug, but rather a limitation. The LSP4IJ plugin, which is what powering the LSP experience under the hood, doesn't expose many things for me to work on.

For example, most of the methods defined in the class handling autocompletions are private ones: If I were to override something I would (likely) have to copy a significant chunk of their code over, or use reflection to get "unauthorized" access and risk breaking all users' workflows if those methods are changed. Neither is a good choice.

I do agree with this, just that I'm unable to find a suitable solution right now.

angelozerr commented 3 months ago

@InSyncWithFoo it seems you need an API again for this usecase. Please create an issue for that.

Can you manage this usecase with lsp jetbrains?

InSyncWithFoo commented 3 months ago

Filed an issue at @redhat-developer/lsp4ij#472.