InTaVia / source-dataset-conversion

scripts and converted datasets accordng to IDM RDF (see IDM RDF repository)
0 stars 0 forks source link

[BS] Time-Spans dont have a class #43

Closed sennierer closed 1 year ago

sennierer commented 1 year ago

I ran the preliminary shacl against the BS dataset. Time-Spans dont seem to have a class:

Constraint Violation in ClassConstraintComponent (http://www.w3.org/ns/shacl#ClassConstraintComponent):
    Severity: sh:Violation
    Source Shape: ex:crm_P4_has_time-span
    Focus Node: <http://www.intavia.eu/bs/event/4559-24>
    Value Node: <http://www.intavia.eu/bs/timespan/22/4559>
    Result Path: crm:P4_has_time-span
    Message: Value does not have class crm:E52_Time-Span
ptleskin commented 1 year ago

Ok, I noticed we have named the class crm:E52_Time_Span, I will change that to the correct one with a hyphen crm:E52_Time-Span

sennierer commented 1 year ago

perfect! thanks!

sennierer commented 1 year ago

thanks for updating that. Commited the new file to the already open PR in the source-data repo and the time-span violations are gone. Still remains the issue with the role_types, but that depends on where we add those triples obviously (added them to APIS for the moment and its valid now).