InVisionApp / go-health

Library for enabling asynchronous health checks in your service
MIT License
750 stars 58 forks source link

fix: change mongodb-boltdb-mock deleted repo ref to new SHA #81

Closed ghost closed 2 years ago

ghost commented 2 years ago

fixes #79

codyaray commented 2 years ago

@dselans @talpert @schigh @helios-ag @chesleybrown @endorama @unguiculus @caledhwa @chrisfjones @maxcnunes

I don't know which of you have permission to merge here anymore, but this should fix a bug that's breaking this for a lot of the users here. See the bug details in https://github.com/InVisionApp/go-health/issues/79.

🙏 help, thanks!

EDIT: I also just emailed the three who appear to still work at InVision. (Chesley, Chris, and Max)

chesleybrown commented 2 years ago

Is this PR still needed? It looks like the repo was restored: https://github.com/zaffka/mongodb-boltdb-mock

Screen Shot 2022-10-18 at 12 39 14 PM
codyaray commented 2 years ago

Yeah, the PR is still needed to fix the SHA sums, otherwise golang won't build right.

(It wasn't "restored" so much as "a new repo was created with a copy of the files... and thus all the hashes are different")

chesleybrown commented 2 years ago

I'm going to merge this into the PR I just opened. I'm trying to add in the required build process so we can get this into master.

Also we require our file-validation check to be passing and unfortunately this will only run on branches from within this repo (not forks). So merging it into my PR first will also run that check for us.

codyaray commented 2 years ago

Thank you so much for the quick response, @chesleybrown !