InZidiuZ / op-framework-issue-tracker

Effective bug-reporting and bug-tracking for op-framework
67 stars 41 forks source link

[game/boomboxes] Alternative to current Boombox implementation #1907

Closed Stretah closed 2 years ago

Stretah commented 3 years ago

Assurance: Assured

Summary: I wanted to find a GitHub script for an alternative to the current implementation of the boombox we currently have in city and have found what I believe is an overall better implementation for music in the city. This would allow not only a better RP experience for players but a more immersive experience for businesses.

Here is the link to the overall suggestion: (https://forum.cfx.re/t/esx-exm-carmusic-musiceverywhere-a-nui-synchronized-music-script-to-animate-your-server-paid/2119764)

Here is the link to the demonstration of this suggestion: (https://streamable.com/sfng79)

Reason: I believe this change would be better overall for the framework as it is scalable, customizable and future proof. This will allow music to be played from cars and placed within business and tied to specific jobs. It also addresses the issue many have had with the current boombox implementation that does not allow for a lot of songs to be played on the current system.

MissDyna commented 3 years ago

yeah i Dislike the fact that none of my songs work accept a few so trying to pick certain songs makes event's difficult !

iGreatWhite commented 3 years ago

It has to deal with APIs that have limits per day. It can only handle so many requests before it rejects all URLs. In addition, it won’t accept anything over 10mins. As well as, there is like 7 legacy servers all with boom boxes so that limit comes pretty quickly. Also the alternative linked in this post, has a dependency for ESX which may not work or have to have some serious rework to even put into the server.

ultrahacx commented 3 years ago

The current setup of boombox has much more that the above mentioned script such as spatial audio which was specially worked for days and goes through a audio conversion process on backend servers for compatibility with spatial audio and also to maintain performance.

With the above boombox setup, it runs the youtube video instance in your Fivem. If you consider that, you have a chrome tab open for each boombox. Imagine 10-15 boomboxes running in the city. It would be a great performance loss depending upon how good the player's PC setup is.

ultrahacx commented 3 years ago

10min song limit might be removed soon as Inzidiuz last mentioned but Im not sure if he even remembers about it. It was implemented as first place to prevent people from playing long songs cause the video needs to be processed to mp3 at backed and then streamed to players which would easily exhaust both API limit and server storage and bandwidth

InZidiuZ commented 3 years ago

It also addresses the issue many have had with the current boombox implementation that does not allow for a lot of songs to be played on the current system.

The linked resource would most likely have way less songs available as well as problems with one player being able to hear the song and another one not being able to.

Stretah commented 3 years ago

Well would there be a way to implement a better music system for businesses and citizens? I'm aware this would take awhile to implement and create but it would benefit everyone as there are tons of people that just want to have a better/less limiting boombox system. I'm not opposed to the boombox; it just doesn't work well currently.

Spencer10798 commented 3 years ago

Does this script only support one song at a time? That's a big step backwards if so. Being able to line up multiple songs is a pretty important feature that the current boombox supports.

InZidiuZ commented 3 years ago

The script linked here seems to be many, many steps backwards compared to the current one. I don't have any intents to add the one suggested, but elements from that one can be taken and applied to our custom one.

Stretah commented 3 years ago

I mean end of the day we just want improvements to be made to the boombox system so whatever works would be helpful.

Stretah commented 3 years ago

I know this might be a big undertaking but would it better to add Spotify integration? I understand this would require client-side authentication to Spotify and not sure if that would run into issues with other hearing the music however could that possibly be implemented?

InZidiuZ commented 3 years ago

Spotify sounds like a major headache that would probably never really work as you might think/hope.

ultrahacx commented 3 years ago

Spotify won't work either way since the CEF aka inbuilt chromium doesnt have EME certification. Even if it would have had EME, managing the Spotify SDK permissions for usage and user login details for Spotify account would not be possible

Stretah commented 3 years ago

Hmm, fair enough. What possible solutions/improvements do you all think could be made to the current system in the future?

InZidiuZ commented 3 years ago

Here are some I have noted down:

There most likely are other things that can be done too, so feel free to come with your own input.

Stretah commented 3 years ago

Good suggestions honestly. I think soundcloud support and the mp3 files would help a lot as well. Would the Mp3 file include client side direct pathing from client machines? I'd assume not because not sure how you'd manage to get that to work.

InZidiuZ commented 3 years ago

No, you'd have to upload them somewhere. An easy place to do so is just dragging & dropping it in a discord channel and copying its link.

Stretah commented 3 years ago

Yeah that makes much more sense to me. I like the idea of all of those changes though. Especially since YT is so limiting on what songs can and can not be used. MP3 files alleviates that issue.

coalaura commented 2 years ago

Closed in favor of #2534