InZidiuZ / op-framework-issue-tracker

Effective bug-reporting and bug-tracking for op-framework
67 stars 41 forks source link

[game/radio] Persist Radio Frequency per radio #2406

Closed MetaHatter closed 1 year ago

MetaHatter commented 2 years ago

Assurance: Have you read through the rules from the README.md file in the root folder of this GitHub repository? Yes

Summary: Write a summary of what your suggestion is about.

Reason: Why would your suggestion be a good change to the framework?

vol5 commented 2 years ago

This is a damn good idea.

Mugdha57 commented 2 years ago

damnn this is a really OP suggestion...

coalaura commented 2 years ago

I like the idea, BUT what if you have multiple radios on you? When you do /freq which one would remember the freqency? On login which frequency would it use if you have multiple?

vol5 commented 2 years ago

Have it default via left to right, top to bottom inventory prio. So, if radio A is in Hotbar slot 1 and radio B is in Hotbar slot 5 it then remembers freq A on login.

MetaHatter commented 2 years ago

I like the idea, BUT what if you have multiple radios on you? When you do /freq which one would remember the freqency? On login which frequency would it use if you have multiple?

Login could either use the last "active" radio, or simply require the user to "use" the radio they want upon login.

coalaura commented 2 years ago

"use" the item to make it the active radio.

what about the radio ui tho

If a unique radio id could be assigned, similar to a license plate, a command could be added to allow hotkey selecting it. (i.e. /radio_select Q3E5RT23)

That sounds like a pain and an ugly solution

MetaHatter commented 2 years ago

"use" the item to make it the active radio.

what about the radio ui tho

Radio UI for the "used" radio would show

If a unique radio id could be assigned, similar to a license plate, a command could be added to allow hotkey selecting it. (i.e. /radio_select Q3E5RT23)

That sounds like a pain and an ugly solution

Open to other suggestions. Would assume most people would just MMB click or "use" the radio they want so may not be necessary at all.

coalaura commented 2 years ago

For now i've added it so the last frequency you were on is remembered for each character and you rejoin it when you load back in

coalaura commented 1 year ago

Ok i dont really think i'd want the frequency to be on the radio tbh. With it saving on the character i think that already basically does the whole remembering part