search

Inareous / Minimal-CS-Manga-Reader

Read your manga continously in one page.
MIT License
16 stars 2 forks source link

Moving the image with a gesture #18

Closed Slasar41 closed 4 years ago

Slasar41 commented 4 years ago

Moving the image with two fingers to the left will result the application to close. Moving to the right works fine.

Inareous commented 4 years ago

I actually cannot test this rigorously as I don't have any touch device, however it shouldn't really be a problem since MCS doesn't manually handle/catch any touch related input.

I tried simulating touch input using Windows Simulator (1, 2) but I can't reproduce the issue. Moving two fingers to any direction works normally, can you try with another device?

Slasar41 commented 4 years ago

Ah sorry it's not a touchscreen but a touchpad. I'm using ASUS Smart Gesture.

Inareous commented 4 years ago

I do use a asus laptop (with asus smart gesture v1.1.1.13) too but I can't reproduce the issue.

All the gesture gets converted by smart gesture as a mouse input to the program. In this case, two fingers to the left should result in a shift + mouse wheel. Try using mouse and scroll using mouse wheel (+ shift for horizontal scroll) to see if the problem exist on mouse too. If it doesn't the problem probably lies on the touchpad converter, however other program like browser shouldn't work too which is kinda impossible. Try other version of asus smart gesture.

Slasar41 commented 4 years ago

I've same version as yours. Scrolling with Shift+Mouse Wheel works fine to left and right. But swipping with two fingers to make the image move to the left will resulting the application to close. Even when there's no horizontal image so there's no horizontal scrollbar but doing the swipping will get the same result.

Inareous commented 4 years ago

After a little bit debugging, this relates to arithmetic overflow on WpfMouseWheelLib.dll which has been fixed. However the project doesn't create a newer release and the current dll we're using is the first release from it's codeproject.

Newly built dll will be shipped in the next release.