Stop depending on strings to be in English

IncPlusPlus / titanfall2-rp

Titanfall 2 Discord Rich Presence

MIT License

8 stars 2 forks source link

Closed IncPlusPlus closed 2 years ago

IncPlusPlus commented 2 years ago

Closes #28 (finally). I totally saw this issue coming a mile away and as it turns out, relying on English strings was a huge mistake.

The one downside of this change is that it introduces #147.

IncPlusPlus commented 2 years ago

I really wanna just send this PR through but I gotta test it some more before it's good to go.

IncPlusPlus commented 2 years ago

Tested all the branches in titanfall2_rp.PresenceUpdateThread.GetDetailsAndState. Looks good!