SyntaxError in generated OpenAPI client

IncQueryLabs / incquery-server-jupyter

IncQuery Server Client Extensions for Jupyter and Python

Apache License 2.0

2 stars 0 forks source link

SyntaxError in generated OpenAPI client #35

Open thSoft opened 3 years ago

thSoft commented 3 years ago

Steps to reproduce:

Spin up a notebook in this repo with MyBinder
Try to execute the first Python code block

Expected output: it is executed successfully

Actual output:

  File "/srv/conda/envs/notebook/lib/python3.7/site-packages/mms_python_client/api/artifact_api.py", line 137
    async=params.get('async'),
        ^
SyntaxError: invalid syntax

Cause: async became a reserved word in Python 3.7, but we use it for the async method family.

abelhegedus commented 3 years ago

https://github.com/OpenAPITools/openapi-generator/issues/7119

bergmanngabor commented 3 years ago

Solved for now in the MyBinder setup: https://github.com/IncQueryLabs/incquery-server-jupyter/commit/a207daf2066c1f8667f256c47541e1b04575a514

It seems the mms client package must be pinned to version 3.4.2.1 until a fix is available upstream.

TODO:

[x] report to MMS guys
[x] update readme / setup guide in the meantime
[ ] update declared package dependencies (pip, conda) in the meantime

bergmanngabor commented 3 years ago

Reported upstream as https://github.com/Open-MBEE/mms-alfresco/issues/346
Added note in README: https://github.com/IncQueryLabs/incquery-server-jupyter/commit/74bb01b3a7af726151d6cc5a741beb996d952c54