search

Incapamentum / Exalted-Sage

Discord bot that does API requests to retrieve a collection of daily achievements for the next day and pushes an alert when any that is in a watchlist shows up.
3 stars 0 forks source link

Configuration - `settings.json` #35

Closed Incapamentum closed 1 year ago

Incapamentum commented 1 year ago

Took a look at the settings.json file, which contains different values such as the bot token, name of the database to pull from, and the address to connect to the database. Although it's somewhat simple, it's best to maintain two separate copies to reduce overall risk.

This is a simple change. Just a matter of having to refactor the relevant code, but in doing so also risks having to figure out how to switch between dev and prod compile-time switches in the code.

Incapamentum commented 1 year ago

Some changes were done, which can be seen in the branched listed on this issue.

Will go ahead and see about testing an update done to one of the functions, which is called on reset (defined as GMT+0 for those unaware), to see whether it'll crash or not.

Incapamentum commented 1 year ago

For the most part, this change hasn't broken anything. One thing to mention, however, is that I made a commit that in hindsight perhaps wasn't intended for the branch created for this issue. This is now noted in #41, which is due to a cancellation token not being available. The specific change can be found in this commit (08208b573bd2cf3b0b1d85938ecbb0e658cfef7a).

Otherwise, I believe this branch is good to go for merging.

Incapamentum commented 1 year ago

Yeah, the copy files over in the .csproj file caused an issue with the workflow. Commenting it out, but there should be a better way of doing this.

Incapamentum commented 1 year ago

Resolved through 0ffea187eb0847f9aa3a53994c20e8acf61a780e. If an issue arises that's specific to the PeriodicAsync task, open a separate issue.