search

Incapamentum / Exalted-Sage

Discord bot that does API requests to retrieve a collection of daily achievements for the next day and pushes an alert when any that is in a watchlist shows up.
3 stars 0 forks source link

Updates to `settings.json` #43

Closed Incapamentum closed 1 year ago

Incapamentum commented 1 year ago

The settings.json is a file used that carries different URIs, such as the token, the DB connection URL, etc. Previously, two objects were being maintained in the file: a dev and a prod. This was then shortened to only carry one object: the VPS service will have the prod copy, with the dev copy being kept locally.

A review will be done later before confirming the pull request.

Incapamentum commented 1 year ago

Before merging, I should go ahead and shut down the VPS service in order to update its copy of settings.json with the intended copy for production.

Two things to mention regarding the changes. The first is that, with the separation of both dev and prod into separate copies, it will no longer be possible to test for the latter. The second is that the project will now copy over settings.json, but I am unsure whether this will affect build workflow.

Incapamentum commented 1 year ago

Going ahead and merging the pull request. Issue will be closed once it's been determined that copying over settings.json in the project file will not cause any issues with the build workflow.