search

Incapamentum / Exalted-Sage

Discord bot that does API requests to retrieve a collection of daily achievements for the next day and pushes an alert when any that is in a watchlist shows up.
3 stars 0 forks source link

[REFACTORING] Introduce a Model parent class #56

Closed Incapamentum closed 1 year ago

Incapamentum commented 1 year ago

Opened following suit from #51. Better to break down the problem into smaller, more manageable parts than have a single issue deal with it.

The goal here is to create a parent class that all model docs inherit from to reduce overall code writing, as they all effectively make use of very similar fields. Also seeks to standardize them across the board, as currently the docs found in the database are not.

Incapamentum commented 1 year ago

Discussion will be moving over to the associated PR.

Incapamentum commented 1 year ago

This issue seems to be solidly intertwined with the DatabaseService.cs file, as many of the API calls done there end up using a lot of the models. Might be worth to look into also refactoring that code, enforcing a 80-char limit on it as well to make it cleaner in general.