search

Incapamentum / Exalted-Sage

Discord bot that does API requests to retrieve a collection of daily achievements for the next day and pushes an alert when any that is in a watchlist shows up.
3 stars 0 forks source link

Remove/Assign `Explorer` role depending on circumstance #61

Closed Incapamentum closed 1 year ago

Incapamentum commented 1 year ago

Best way to explain the changes being merged via this PR:

As a user joins the server, a bot (not this one!) assigns the Explorer role. This enables the user to see certain specific channels. Once they go through an application process, a bot (again, not this one and different than the previously mentioned one) assigns the user the Gilded role. However, the Explorer role is not automatically removed.

Similarly, if the user ends up being removed from the in-game guild, a bot (at this point, you should know it's not this one) removes the Gilded role, but the Explorer role is never reassigned, so the user ends up being in a weird state of limbo.

The changes being worked on is a new feature, so this will increase the minor version. What the bot should do is to remove the Explorer role if the user receives the Gilded role, and have the former be reassigned upon the lose of the latter. Straight-forward, right?

Relevant issue to this can be tracked via #60, where it's mostly me realizing I did something dummy, but for the sake of documenting, I talked about it.

Incapamentum commented 1 year ago

Changes should be good to go for this tick-cycle.

Incapamentum commented 1 year ago

I should mention that this will be a live test due to how the feature is meant to work in tandem with other bots, so it's difficult to come up with a practical test for these changes. Here goes nothing tho :^)