search

Incendo / cloud-minecraft

Integrations between Minecraft and Cloud Command Framework
https://cloud.incendo.org/minecraft/
MIT License
25 stars 8 forks source link

Bukkit PlayerParser suggestions don't work #58

Closed DiamondDagger590 closed 5 months ago

DiamondDagger590 commented 5 months ago

The PlayerParser from cloud-bukkit does not work as intended for providing suggestions.

Edit: See below comment. TLDR: I had no idea console could tab complete in the year of our lord 2024 (been MIA for a bit) and misdiagnosed the issue

DiamondDagger590 commented 5 months ago

Update:

The code was failing due to a NoSuchMethodError when tab completing, resulting in no in game results being provided and console tab completion (didn't realize that was a thing until literally just now lol) errors out due to missing Suggestion#simple.

Changing Suggestion#simple to Suggestion#suggestion fixes this where tab completion works for both console and player in game with the existing filter statement.

The following are my dependencies when I experience this error:

    val cloudVersion = "2.0.0-beta.4"
    api("org.incendo:cloud-paper:$cloudVersion")
    api("org.incendo:cloud-annotations:$cloudVersion")
    api("org.incendo:cloud-minecraft-extras:$cloudVersion")
DiamondDagger590 commented 5 months ago

Looking further at the code, this change was already actually put in place (-beta.5 is out now) so ticket can be resolved.