search

Incendo / cloud

Command framework & dispatcher for the JVM
https://cloud.incendo.org
MIT License
433 stars 54 forks source link

feat(core): Replace compound arguments with specialized aggregate parser builders #719

Closed jpenilla closed 6 months ago

jpenilla commented 6 months ago

fixes #711

also fixes the resulting type(token)s (literal Pair<U extends Object, V extends Object> -> actual type ie Pair<String, Integer>)

github-actions[bot] commented 6 months ago

Test Results

 85 files  ±0   85 suites  ±0   12s :stopwatch: ±0s 418 tests ±0  418 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  462 runs  ±0  462 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 32b334d7. ± Comparison against base commit 895813f1.

:recycle: This comment has been updated with latest results.

Machine-Maker commented 6 months ago

Does it have to be setup such that you first have to add the parsers to the ParserRegistry? I pretty much never use that cause I don't use annotations. Being able to set the types+parser directly instead of having to go through 1 extra step would be nice.-

jpenilla commented 6 months ago

I've added some factory methods that take ParserDescriptors, I'm not sure about adding even more methods to Command.Builder though.