search

Inchoo / Inchoo_PHP7

PHP 7 compatibility extension for Magento 1 (DEPRECATED!!)
MIT License
353 stars 112 forks source link

Does 1.9.3.10 include this (or Magento's) PHP 7.2 fixes? #151

Open durzel opened 6 years ago

durzel commented 6 years ago

Apologies the indirect line of enquiry...

The README says that Magento have released a patch for PHP 7.2 support, which depreciates this extension. It is not clear however whether Magento 1.9.3.10 - released on on 18th September - also includes these fixes? I can't see an obvious reason why they wouldn't be given that this extension plays perfectly nicely with core.

I haven't had the opportunity to investigate myself yet, am just conscious about upgrading to 1.9.3.10 and assuming that the fixes are rolled in, or likewise assuming they are not.

kanevbg commented 6 years ago

I have done the checks - the support for PHP7 is not included in 1.9.3.10

matinfo commented 6 years ago

Yes, is two different thing :-)

The newly release 1.9.3.10 include all the last security fixe. The PHP7.2 patch make magento working with PHP7.2. Not every platform using 1.9.3.10 use PHP7.2!

durzel commented 6 years ago

Thanks. It does seem odd, particularly as Magento haven't listed 1.9.3.10 on the list of versions that require SUPEE patches (1.9.3.9 is listed and says it needs no patches). The implication - to me - is that the PHP 7 support was rolled into 1.9.3.10.

Thanks for clarifying.

udovicic commented 6 years ago

Hi, Patch was created before the 1.9.3.10 was created, but was not included in that release. It will be part of core starting from 1.9.4.0 and on. As for the naming of the patch, you should use the same one as for 1.9.3.9. Unfortunately, that was not renamed or noted before publishing it to Magento download pages, but has been confirmed.