search

Inchoo / Inchoo_PHP7

PHP 7 compatibility extension for Magento 1 (DEPRECATED!!)
MIT License
352 stars 112 forks source link

Topological order for totals calculation not in offical patch? #152

Open stollr opened 6 years ago

stollr commented 6 years ago

In the README.md of this repository it says

Magento released official PHP 7.2 patches for Magento 1 (September 2018), which means this extension is not needed anymore!!

But as far as I can see, the fix for the topological order for the totals calculation (see 1c1c5e452eb77b71e578d2f66d2aa4ca59628fcb) is not included in the official patch and has been reverted in master branch in commit 6b2fa1c5891a96e574f162361fa1ac637c13f34d.

What is the reason for that. Because in a shop, I am supporting, the old order fix does not fix the sorting with the third party extension Customweb/Subscriptions.

seansan commented 5 years ago

can you find it in LTS? https://github.com/OpenMage/magento-lts

stollr commented 5 years ago

@seansan As far as I see it is not included there, too.