search

Incubaid / arakoon

A consistent distributed key-value store
http://arakoon.org
Apache License 2.0
84 stars 17 forks source link

Remove unused `String_extra` module #420

Closed NicolasT closed 10 years ago

toolslive commented 10 years ago

is used in nursery, and 3.0 (prefix_match)

NicolasT commented 10 years ago

Indeed it is in 3.0 (so a forward merge will need some care). Not sure about nursery?

[nicolas@chi arakoon (1.7 %)]$ git show-ref refs/heads/1.7
891800e81dae4046f2e4286e6b0e6ef176ad60d9 refs/heads/1.7
[nicolas@chi arakoon (1.7 %)]$ git grep prefix_match
src/tools/string_extra.ml:let prefix_match prefix k =
domsj commented 10 years ago

Another option is moving that function to Std.String

NicolasT commented 10 years ago

Agree (in 3.0).

domsj commented 10 years ago

Ok, LGTM