search

Incubaid / arakoon

A consistent distributed key-value store
http://arakoon.org
Apache License 2.0
84 stars 17 forks source link

Remove custom GC configuration #446

Closed NicolasT closed 10 years ago

NicolasT commented 10 years ago

During some non-real-world benchmarking (single-node cluster, fsync disabled, running in tmpfs) it turned out the custom GC configuration as set up by Arakoon has a non-negligible performance impact: the set scenario of the built-in benchmark goes from +- 115s to +- 93s.

It looks like the default GC settings (of OCaml 4.01.0) are better suited for the Arakoon workload.

Next to this, the custom settings removed the ability to set site-specific configurations using OCAMLRUNPARAM.

NicolasT commented 10 years ago

Will run CI and report how this influences the runtime.

toolslive commented 10 years ago

historical note: These settings were engineered (trial, error and bisect) to make the monkey stay under 128MB while it rattled its cage. At that time, this was considered more important than raw performance. LGTM

NicolasT commented 10 years ago

Thanks for that clarification :+1: Luckily we're not running 128MB nodes anymore, and if one does, OCAMLRUNPARAM can come to the rescue :smiley: