Incubaid / arakoon

A consistent distributed key-value store
http://arakoon.org
Apache License 2.0
84 stars 17 forks source link

make closing a tlog with the correct marker a bit easier #481

Closed domsj closed 10 years ago

NicolasT commented 10 years ago

Maybe consider changing or duplicating system_tests_basic:test_marker_presence_required to use this mechanism so it's 'tested' as well?

domsj commented 10 years ago

I've expanded system_tests_basic:test_marker_presence_required a bit to test this mechanism. (Still waiting on CI)

Do you think the extra -close is clear enough? I could instead make a real separate call --close-tlog...

NicolasT commented 10 years ago

I was thinking about that yesterday as well.Having 2 top-level actions might be confusing as well though?

NicolasT commented 10 years ago

OK if CI is happy.