Closed khenderick closed 9 years ago
As a historical note: this replaces #513 .
LGTM. As long as .deb build scripts are in here I think it's fine for .rpm build scripts to be here too.
IMHO it lacks quite a couple of things:
LICENSE
or COPYING
file, which is installed in /usr/share/doc/<packagename>
, using %doc COPYING
in the %files
sectionRelease
field should most likely carry a %{?dist}
suffix (1%{?dist}
)BuildRequires
and Requires
fields)Source0
field (currently the package sources seem to come out of thin air)ExclusiveArch
, since Arakoon is basically only tested & supported on x86_64%{_bindir}
instead of hard-coded /usr/bin
${buildroot}
instead of $RPM_BUILD_ROOT
%check
section which invokes the Arakoon unit tests (which ensures the build actually runs)URL
%changelog
A good read on RPM packaging: https://fedoraproject.org/wiki/How_to_create_an_RPM_package
LGTM (assuming it works :wink: )
Added support for creating rpm packages.