search

IndEcol / IE_data_commons

Code and documentation for a commons of structured industrial ecology data
MIT License
23 stars 2 forks source link

Changes of IEDC Excel data template and export routines #5

Open stefanpauliuk opened 6 years ago

stefanpauliuk commented 6 years ago

Note necessary and optional changes here so that they can be reviewed and become part of next version.

nheeren commented 6 years ago

So this is something like a wishlist :christmas_tree:? Let me add one thing. Parsing the Cover sheet was a quite tedious. We should rethink that. I can make a proposal.

stefanpauliuk commented 6 years ago

Sure, we can design a version 2 format. Note that the left part of the cover sheet is just a 1:1 copy of the dataset table entry. Here we don't have much flexibility.

nheeren commented 5 years ago

Another thing: IMO there should be no distinction between TABLE and LIST type data. The LIST type is basically a simple from of the TABLE type. Therefore the definitions of aspects & classifications (currently in the Cover sheet) should be 100% harmonized between the two. Right now I have to use a lot of case distinctions in my code which could be simplified then.

stefanpauliuk commented 5 years ago

When creating a custom classification directly from the data template, we have now: classification_Name = aspect_datasetName, e.g. commodity__1_F_steel_SankeyFlows_2008_Global

Please change the parser to do the following:

nheeren commented 5 years ago
  • for meaning_attribute1: from "None" to "[aspect] aspect of dataset"

Do you mean that literally or should "[aspect]" be replaced with something? Please give an example.

stefanpauliuk commented 5 years ago

Please replace [aspect] by the actual aspect (aspect.aspect for aspect.id = datasets.aspectx). E.g. "origin_region aspect of dataset" "age-cohort aspect of dataset"

nheeren commented 5 years ago
  • for description: from "generated by IEDC_tools v0.2" to "Custom classification, generated by IEDC_tools v0.2"
  • for meaning_attribute1: from "None" to "[aspect] aspect of dataset"

Done.