search

IndEcol / IE_data_commons

Code and documentation for a commons of structured industrial ecology data
MIT License
23 stars 2 forks source link

Missing units in units table #9

Closed nheeren closed 5 years ago

nheeren commented 6 years ago

Missing units are (will update as I go along):

List not final yet

Should IEDC_tools create them if found in an Excel template file or who has authority here?

For now I will create them manually in the review DB.

stefanpauliuk commented 6 years ago

To avoid a mess with units, new units will be entered by project team members only.

Mt is already in the db, but not as 'Mt' but as 'Tg'. To allow for more than one unit code, there are three columns in total: unitcode | alt_unitcode | alt_unitcode2 and the upload interface should look in all three columns to find a match. Right now, 'Mt' is not there and needs to be entered as alt_unitcode for id = 46

Litre does not exist yet and needs to be created.

There is a least one more problem with the current unit table: 'µ' was turned into 'æ' at some point.

I suggest we talk about these unit table fixes during our next meeting and then implement all changes in one go.

nheeren commented 6 years ago

Sounds good.

and the upload interface should look in all three columns to find a match.

This is a todo for me then.

nheeren commented 6 years ago

Lookup across three columns implemented: https://github.com/IndEcol/IEDC_tools/commit/30974e3fb5b2a59e37623c44488cc1927bfb24e6

nheeren commented 5 years ago

I added the following: kt (to Gg) and BYen

konstantinstadler commented 5 years ago

If you need a curated list see https://github.com/HajoRijgersberg/OM and http://www.semantic-web-journal.net/content/ontology-units-measure-and-related-concepts

nheeren commented 5 years ago

Resolved for now. Would be nice to implement something like Konstantin suggested in the future.