Closed hazimhussein closed 1 year ago
konstantinstadler
commented
1 year ago seems like you did not format (black and isort) the pull request. You can have a look into the format_and_test.sh file on how to do that. This is a linux file, but you can copy paste the commands in cml or write your own bat file (actually, you could translate/make a format_and_test.bat similar to the sh file for convinience, just push it with a pull request when you see that it is working)
konstantinstadler
commented
1 year ago which version of black are you using for the linting?
From: Hazim Hussein @.> Sent: Wednesday, April 19, 2023 15:51 To: IndEcol/pymrio @.> Cc: Konstantin Stadler @.>; Comment @.> Subject: Re: [IndEcol/pymrio] Gloria downloader (PR #104)
@hazimhussein commented on this pull request.
In doc/source/notebooks/advanced_group_stressors.ipynbhttps://github.com/IndEcol/pymrio/pull/104#discussion_r1171377787:
@@ -34,7 +34,7 @@ "metadata": {}, "outputs": [], "source": [
- "wiod_folder = '/tmp/mrios/WIOD2013'"
- "wiod_folder = \"/tmp/mrios/WIOD2013\""
This is done automatically by black
— Reply to this email directly, view it on GitHubhttps://github.com/IndEcol/pymrio/pull/104#discussion_r1171377787, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABTX7S2CV2XHWFDU2VCN5R3XB7UXXANCNFSM6AAAAAAXCJUZQQ. You are receiving this because you commented.Message ID: @.***>
hazimhussein
commented
1 year ago It is 23.3.0
But black package alone didn’t work on jupyter notebook, I had to download another dependency “black-jupyter” also version 23.3.0
From: Konstantin Stadler @.> Sent: Wednesday, April 19, 2023 4:02 PM To: IndEcol/pymrio @.> Cc: Hazim Hussein @.>; Mention @.> Subject: Re: [IndEcol/pymrio] Gloria downloader (PR #104)
which version of black are you using for the linting?
From: Hazim Hussein @.<mailto:@.>> Sent: Wednesday, April 19, 2023 15:51 To: IndEcol/pymrio @.<mailto:@.>> Cc: Konstantin Stadler @.<mailto:@.>>; Comment @.<mailto:@.>> Subject: Re: [IndEcol/pymrio] Gloria downloader (PR #104)
@hazimhussein commented on this pull request.
In doc/source/notebooks/advanced_group_stressors.ipynbhttps://github.com/IndEcol/pymrio/pull/104#discussion_r1171377787:
@@ -34,7 +34,7 @@ "metadata": {}, "outputs": [], "source": [
- "wiod_folder = '/tmp/mrios/WIOD2013'"
- "wiod_folder = \"/tmp/mrios/WIOD2013\""
This is done automatically by black
— Reply to this email directly, view it on GitHubhttps://github.com/IndEcol/pymrio/pull/104#discussion_r1171377787, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABTX7S2CV2XHWFDU2VCN5R3XB7UXXANCNFSM6AAAAAAXCJUZQQ. You are receiving this because you commented.Message ID: @.<mailto:@.>>
— Reply to this email directly, view it on GitHubhttps://github.com/IndEcol/pymrio/pull/104#issuecomment-1514791641, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG7SFTO4BGVMDL5O3X6MZZ3XB7V43ANCNFSM6AAAAAAXCJUZQQ. You are receiving this because you were mentioned.Message ID: @.**@.>>
This branch contains the implementation of the GLORIA downloader and the related documentation