IndEcol / pymrio

Multi-Regional Input-Output Analysis in Python.
http://pymrio.readthedocs.io/en/latest/
Other
155 stars 71 forks source link

[Issue #42] OS-dependent path in tools/ioparser.py #49

Closed Didou09 closed 3 years ago

Didou09 commented 3 years ago

Motivations:

Main changes:

Issues:

Indeed, when checking the content from my github cloned repo:

(base) ls /home/didier/Documents/Projects/pymrio/pymrio/mrio_models/
total 16K
drwxrwxr-x 4 didier didier 4,0K oct.  30 15:01 .
drwxrwxr-x 7 didier didier 4,0K oct.  30 16:13 ..
drwxrwxr-x 4 didier didier 4,0K oct.  30 15:01 exio20
-rw-rw-r-- 1 didier didier    0 oct.  30 15:01 __init__.py
drwxrwxr-x 3 didier didier 4,0K oct.  30 15:01 test_mrio

When checking from the pip-installed version:

(base) ls /home/didier/anaconda3/lib/python3.7/site-packages/pymrio/mrio_models/
total 16K
drwxrwxr-x 4 didier didier 4,0K oct.  30 14:48 .
drwxrwxr-x 6 didier didier 4,0K oct.  30 14:48 ..
-rw-rw-r-- 1 didier didier    0 oct.  30 14:48 __init__.py
drwxrwxr-x 2 didier didier 4,0K oct.  30 14:48 __pycache__
drwxrwxr-x 4 didier didier 4,0K oct.  30 14:48 test_mrio

Clearly, exio20 is not included in the pip installation, which means users using pip will have the same issue even after this PR. Opening a separate issue to deal with this, which should be done both in the setup.py and in a MANIFEST.in from what I know.