Characterized impacts of final demand not parsed properly as `F_Y` in EXIOBASE3

IndEcol / pymrio

Multi-Regional Input-Output Analysis in Python.

http://pymrio.readthedocs.io/en/latest/

Other

155 stars 71 forks source link

Characterized impacts of final demand not parsed properly as `F_Y` in EXIOBASE3 #91

Open thomasgibon opened 2 years ago

thomasgibon commented 2 years ago

Hi! I found this small issue in parsing EXIOBASE3 data, whereby F_Y only exists for the satellite extension, but is of type None in the impacts extension.

This happens because renaming F_hh to F_Y is done for satellite but not impacts, here: https://github.com/konstantinstadler/pymrio/blob/31a4a078d43b5ac293766d6e635e019084e4bc91/pymrio/tools/ioparser.py#L708

So, here, just for consistency's sake 😄

fmcardoso commented 2 years ago

I have checked the data for some years, and I am unable to reproduce this issue.

This issue seems to be already solved, or there is not enough context for reproducing it.

on-behalf-of: @clarityai-eng

@jherrlo @rfbelo