IndaloTech / ramses_esp

Port evofw3 to Espressif ESP32-S3
8 stars 0 forks source link

CR LF characters between messages #1

Closed brucemiranda closed 5 months ago

brucemiranda commented 8 months ago

On the ESP device, the very first message is not appearing on a new line because of a missing CR LF between the debug messages of the bootloader and the first message.

Also all subsequent messages have CR CR LF printed between two messages rather than just CR LF..So depending on the text editor used, shows a blank line between messages.

This might also cause a problem for the processing program, if its using CR LF as the delimiter.

zxdavb commented 8 months ago

For reference, this is what I see:

Tx:     b'RQ --- 18:000730 01:145038 --:------ 2E04 001 FF\r\n'
Rx:     b'RQ --- 18:000730 01:145038 --:------ 2E04 001 FF\r\n'
Rx: b' 000 RQ --- 18:017804 01:145038 --:------ 2E04 001 FF\r\r\n'
Rx: b' \r\n'
Rx: b' 053 RP --- 01:145038 18:017804 --:------ 2E04 008 00FFFFFFFFFFFF00\r\r\n'

In addition to the extra \r previously described (and of no consequence to ramses_rf), there is a leading space (which will cause the packet to be considered corrupt).

... this is what I am expecting (i.e. the behaviour of a HGI80):

Tx:     b'RQ --- 18:000730 01:145038 --:------ 2E04 001 FF\r\n'                # the send
Rx: b'000 RQ --- 18:017804 01:145038 --:------ 2E04 001 FF\r\n'                # the echo
Rx: b'053 RP --- 01:145038 18:017804 --:------ 2E04 008 00FFFFFFFFFFFF00\r\n'  # the reply
ghoti57 commented 5 months ago

Fixed in v0.4.0