search

Indatus / dispatcher

Dispatcher is a Laravel artisan command scheduling tool used to schedule artisan commands within your project so you don't need to touch your crontab when deploying.
MIT License
1.06k stars 70 forks source link

Doesn't propagate --env flag #127

Closed collegeman closed 9 years ago

collegeman commented 9 years ago

My App::detectEnvironment defaults to local. I can run php artisan schedule:run --env=production, but Dispatcher doesn't propagate the env flag to the commands that are scheduled to run. I think the solution is just to add --env=$environment where $environment is set to App::environment() to the $commandPieces array before line 202 in CommandService.

collegeman commented 9 years ago

Oh weird, I just discovered this fix is already in master. Why do I not have the latest via composer?

collegeman commented 9 years ago

Can you guys please release 1.4.2 up to this commit: https://github.com/Indatus/dispatcher/commit/fdd23d75e4cfbd9ccddd724c742773b4edc4c2e5

collegeman commented 9 years ago

I just need that Environment fix to be available to my Laravel 4 application.

bkuhl commented 9 years ago

Done: https://github.com/Indatus/dispatcher/releases/tag/v1.4.2

The master branch was working towards a Laravel 5 implementation which has since been discontinued so this is based off of the 1.4 branch.

collegeman commented 9 years ago

Bad ass! On Tue, Mar 17, 2015 at 4:42 PM Ben Kuhl notifications@github.com wrote:

Done: https://github.com/Indatus/dispatcher/releases/tag/v1.4.2

The master branch was working towards a Laravel 5 implementation which has since been discontinued so this is based off of the 1.4 branch.

— Reply to this email directly or view it on GitHub https://github.com/Indatus/dispatcher/issues/127#issuecomment-82589172.