search

Indemnity83 / SolderToolbelt

A tool for working with TechnicSolder
MIT License
2 stars 2 forks source link

Improve mod information discovery #10

Open Indemnity83 opened 9 years ago

Indemnity83 commented 9 years ago

When attempting to pack Schematica-1.7.10-1.7.6.129-universal.jar I get the following fatal error:

Fatal error: Cannot use object of type stdClass as array in ModCommand.php on line 222

Also, there is no handling for some common, but non-standard mods such as CodeChickenCore which uses a cccmod.info file (for whatever reason). Any others should be added to this thread until its closed then new issues can be opened for other one-off cases which will be evaluated for their legitimacy.

EntranceJew commented 9 years ago

This happens because on ModCommand.php#L199 we're trying to get the property $modList->modlist but the correct name for the property is $modList->modList for that file.

Indemnity83 commented 9 years ago

Yeah; I realized that after spending a few minutes in the code; I'm expanding this issue though and improving the handling of the json decode for various situations.