[READY TO MERGE] Adds node CI, Updates readme

IndiaCFG3 / team-64

MIT License

4 stars 0 forks source link

[READY TO MERGE] Adds node CI, Updates readme #4

Closed oke-aditya closed 4 years ago

oke-aditya commented 4 years ago

Updates the readme
Adds the CI for node.js. Currently we have no tests (we won't have them most probably)
It just does npm install. So our package.json is verified if it works.
@subhrapaladhi It will be great if you can write a simple test in file test.js. Just run index.js and check if we are up with server.

I don't want to mess up package.json etc. So I didn't write test.js. Just left it empty.

I referred here

oke-aditya commented 4 years ago

DO NOT Merge it as of now. It has some error. I will change PR heading to merge.

subhrapaladhi commented 4 years ago

@oke-aditya You mean a simple route just to test if the server is running or not? Otherwise, I know how to write tests with mocha and chai (testing libraries in node js) but they take a lot of time.

oke-aditya commented 4 years ago

I am unsure @subhrapaladhi how tests are written in node.js. You can write a simple test to check if server is up and running. Suggestion is merge this PR. In a new PR Write the test.js just to check if server is running or not. You may or may not use mocha or chai. Just ensure that in the new PR. Node CI tests pass.

oke-aditya commented 4 years ago

@subhrapaladhi This is ready to go in master. It will update CI of master.