search

IndiaVaccineIN / india-vaccine-frontend

We’re Making it Easier to Locate Vaccination Centers in India
https://www.indiavaccine.in
11 stars 12 forks source link

Added no results message #22

Closed shubh128 closed 3 years ago

shubh128 commented 3 years ago

Resolved Issue #16 No results available message shown if no vaccination centres are available image

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/indiavaccine/india-vaccine-frontend-new/AfzEYDtS5A2LjMWqkxENp9eHiEDB
✅ Preview: https://india-vaccine-git-issue17-no-result-msg-india-9806d0.vercel.app

preetjdp commented 3 years ago

@shubh128 There seem to be some extra linting changes in the PR

Could you run the following command and push that changes?

npm run prettify
preetjdp commented 3 years ago

It shows No results available when the page data is loading

It should show No results available only when the API returns no data, could you handle this case?

https://user-images.githubusercontent.com/27439197/117145283-9e906c80-add0-11eb-9d0a-ec0cfb248ea4.mov

shubh128 commented 3 years ago

Sure I'll look into this

shubh128 commented 3 years ago

Fixed the double message bug However running npm run prettify doesn't change anything in availability_results.tsx